-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
ide: Implement disk shock protection support (v4)
On user request (through sysfs), the IDLE IMMEDIATE command with UNLOAD FEATURE as specified in ATA-7 is issued to the device and processing of the request queue is stopped thereafter until the specified timeout expires or user space asks to resume normal operation. This is supposed to prevent the heads of a hard drive from accidentally crashing onto the platter when a heavy shock is anticipated (like a falling laptop expected to hit the floor). Port resets are deferred whenever a device on that port is in the parked state. v3: Elias Oltmanns <eo@nebensachen.de> wrote: [...] > >> 1. Make sure that no negative value is being passed to > >> jiffies_to_msecs() in ide_park_show(). > >> 2. Drop the superfluous variable hwif in ide_special_rq(). > >> 3. Skip initialisation of task and tf in ide_special_rq() if we are not > >> handling a (un)park request. > > > > Well, #3 should have been done differently because we donn't want to > > check for REQ_(UN)?PARK_HEADS more often than is necessary. > > While preparing the backport to 2.6.27, it has just occurred to me that > we need to clear the IDE_DFLAG_PARKED flag in ide_disk_pre_reset() > because this flag must not be set after *any* sort of access to the > device. v4: Fix a memory leak due to a missing blk_put_request() in issue_park_cmd(). Additionally, we should plug the queue when enqueueing the unpark request because there is no guarantee that the park timeout has not expired by then. Even though the chance for that to happen is very slim, the request might end up hanging in the queue until the next I/O operation is queued up. While at it, clean up the code a little: - make issue_park_cmd() a function of type void since nobody cares for the return value anyway; - use blk_start_queueing() instead of __blk_run_queue() since we don't have to worry about recursion; - remove a superfluous pointer deference in task_no_data_intr(). Signed-off-by: Elias Oltmanns <eo@nebensachen.de> Cc: Jeff Garzik <jeff@garzik.org>, Cc: Randy Dunlap <randy.dunlap@oracle.com> Cc: Tejun Heo <htejun@gmail.com> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
- Loading branch information
Elias Oltmanns
authored and
Bartlomiej Zolnierkiewicz
committed
Oct 13, 2008
1 parent
08243ba
commit 4abdc6e
Showing
8 changed files
with
206 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,121 @@ | ||
| #include <linux/kernel.h> | ||
| #include <linux/ide.h> | ||
| #include <linux/jiffies.h> | ||
| #include <linux/blkdev.h> | ||
|
|
||
| DECLARE_WAIT_QUEUE_HEAD(ide_park_wq); | ||
|
|
||
| static void issue_park_cmd(ide_drive_t *drive, unsigned long timeout) | ||
| { | ||
| struct request_queue *q = drive->queue; | ||
| struct request *rq; | ||
| int rc; | ||
|
|
||
| timeout += jiffies; | ||
| spin_lock_irq(&ide_lock); | ||
| if (drive->dev_flags & IDE_DFLAG_PARKED) { | ||
| ide_hwgroup_t *hwgroup = drive->hwif->hwgroup; | ||
| int reset_timer; | ||
|
|
||
| reset_timer = time_before(timeout, drive->sleep); | ||
| drive->sleep = timeout; | ||
| wake_up_all(&ide_park_wq); | ||
| if (reset_timer && hwgroup->sleeping && | ||
| del_timer(&hwgroup->timer)) { | ||
| hwgroup->sleeping = 0; | ||
| hwgroup->busy = 0; | ||
| blk_start_queueing(q); | ||
| } | ||
| spin_unlock_irq(&ide_lock); | ||
| return; | ||
| } | ||
| spin_unlock_irq(&ide_lock); | ||
|
|
||
| rq = blk_get_request(q, READ, __GFP_WAIT); | ||
| rq->cmd[0] = REQ_PARK_HEADS; | ||
| rq->cmd_len = 1; | ||
| rq->cmd_type = REQ_TYPE_SPECIAL; | ||
| rq->special = &timeout; | ||
| rc = blk_execute_rq(q, NULL, rq, 1); | ||
| blk_put_request(rq); | ||
| if (rc) | ||
| goto out; | ||
|
|
||
| /* | ||
| * Make sure that *some* command is sent to the drive after the | ||
| * timeout has expired, so power management will be reenabled. | ||
| */ | ||
| rq = blk_get_request(q, READ, GFP_NOWAIT); | ||
| if (unlikely(!rq)) | ||
| goto out; | ||
|
|
||
| rq->cmd[0] = REQ_UNPARK_HEADS; | ||
| rq->cmd_len = 1; | ||
| rq->cmd_type = REQ_TYPE_SPECIAL; | ||
| elv_add_request(q, rq, ELEVATOR_INSERT_FRONT, 1); | ||
|
|
||
| out: | ||
| return; | ||
| } | ||
|
|
||
| ssize_t ide_park_show(struct device *dev, struct device_attribute *attr, | ||
| char *buf) | ||
| { | ||
| ide_drive_t *drive = to_ide_device(dev); | ||
| unsigned long now; | ||
| unsigned int msecs; | ||
|
|
||
| if (drive->dev_flags & IDE_DFLAG_NO_UNLOAD) | ||
| return -EOPNOTSUPP; | ||
|
|
||
| spin_lock_irq(&ide_lock); | ||
| now = jiffies; | ||
| if (drive->dev_flags & IDE_DFLAG_PARKED && | ||
| time_after(drive->sleep, now)) | ||
| msecs = jiffies_to_msecs(drive->sleep - now); | ||
| else | ||
| msecs = 0; | ||
| spin_unlock_irq(&ide_lock); | ||
|
|
||
| return snprintf(buf, 20, "%u\n", msecs); | ||
| } | ||
|
|
||
| ssize_t ide_park_store(struct device *dev, struct device_attribute *attr, | ||
| const char *buf, size_t len) | ||
| { | ||
| #define MAX_PARK_TIMEOUT 30000 | ||
| ide_drive_t *drive = to_ide_device(dev); | ||
| long int input; | ||
| int rc; | ||
|
|
||
| rc = strict_strtol(buf, 10, &input); | ||
| if (rc || input < -2) | ||
| return -EINVAL; | ||
| if (input > MAX_PARK_TIMEOUT) { | ||
| input = MAX_PARK_TIMEOUT; | ||
| rc = -EOVERFLOW; | ||
| } | ||
|
|
||
| mutex_lock(&ide_setting_mtx); | ||
| if (input >= 0) { | ||
| if (drive->dev_flags & IDE_DFLAG_NO_UNLOAD) | ||
| rc = -EOPNOTSUPP; | ||
| else if (input || drive->dev_flags & IDE_DFLAG_PARKED) | ||
| issue_park_cmd(drive, msecs_to_jiffies(input)); | ||
| } else { | ||
| if (drive->media == ide_disk) | ||
| switch (input) { | ||
| case -1: | ||
| drive->dev_flags &= ~IDE_DFLAG_NO_UNLOAD; | ||
| break; | ||
| case -2: | ||
| drive->dev_flags |= IDE_DFLAG_NO_UNLOAD; | ||
| break; | ||
| } | ||
| else | ||
| rc = -EOPNOTSUPP; | ||
| } | ||
| mutex_unlock(&ide_setting_mtx); | ||
|
|
||
| return rc ? rc : len; | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters