Skip to content

Commit

Permalink
dm: run queue on re-queue
Browse files Browse the repository at this point in the history
Without kicking queue, requeued request may stay forever in
the queue if there are no other I/O activities to the device.

The original error had been in v2.6.39 with commit 7eaceac
("block: remove per-queue plugging"), which replaced conditional
plugging by periodic runqueue.

Commit 9d1deb8 in v4.1-rc1 removed the periodic runqueue
and the problem started to manifest.

Fixes: 9d1deb8 ("dm: don't schedule delayed run of the queue if nothing to do")
Signed-off-by: Jun'ichi Nomura <j-nomura@ce.jp.nec.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
  • Loading branch information
Junichi Nomura authored and Mike Snitzer committed May 26, 2015
1 parent ba155e2 commit 4ae9944
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions drivers/md/dm.c
Original file line number Diff line number Diff line change
Expand Up @@ -1164,6 +1164,7 @@ static void old_requeue_request(struct request *rq)

spin_lock_irqsave(q->queue_lock, flags);
blk_requeue_request(q, rq);
blk_run_queue_async(q);
spin_unlock_irqrestore(q->queue_lock, flags);
}

Expand Down

0 comments on commit 4ae9944

Please sign in to comment.