Skip to content

Commit

Permalink
drm/xe/guc_pc: Remove duplicated pc_start call
Browse files Browse the repository at this point in the history
xe_guc_pc_start() was getting called from both
xe_uc_init_hw() and from xe_guc_start().

But both are called from do_gt_restart() and only
xe_uc_init_hw() is called at initialization.

So, let's remove the duplication in the regular gt_restart
path.

The only place where xe_guc_pc_start() won't get called now
is on the gt_reset failure path. However, if gt_reset has
failed, it is really unlikely that the PC start will work
or is desired.

Cc: Vinay Belgaumkar <vinay.belgaumkar@intel.com>
Reviewed-by: Jonathan Cavitt <jonathan.cavitt@intel.com>
Reviewed-by: Vinay Belgaumkar <vinay.belgaumkar@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20250306220643.1014049-1-rodrigo.vivi@intel.com
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
(cherry picked from commit fc858dd)
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
  • Loading branch information
Rodrigo Vivi authored and Lucas De Marchi committed Mar 13, 2025
1 parent 626fb11 commit 4b22f19
Showing 1 changed file with 0 additions and 8 deletions.
8 changes: 0 additions & 8 deletions drivers/gpu/drm/xe/xe_guc.c
Original file line number Diff line number Diff line change
Expand Up @@ -1496,14 +1496,6 @@ void xe_guc_stop(struct xe_guc *guc)

int xe_guc_start(struct xe_guc *guc)
{
if (!IS_SRIOV_VF(guc_to_xe(guc))) {
int err;

err = xe_guc_pc_start(&guc->pc);
xe_gt_WARN(guc_to_gt(guc), err, "Failed to start GuC PC: %pe\n",
ERR_PTR(err));
}

return xe_guc_submit_start(guc);
}

Expand Down

0 comments on commit 4b22f19

Please sign in to comment.