Skip to content

Commit

Permalink
ahci-platform: Add support for an optional regulator for sata-target …
Browse files Browse the repository at this point in the history
…power

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
  • Loading branch information
Hans de Goede authored and Tejun Heo committed Feb 22, 2014
1 parent 156c588 commit 4b3e603
Show file tree
Hide file tree
Showing 3 changed files with 37 additions and 2 deletions.
1 change: 1 addition & 0 deletions Documentation/devicetree/bindings/ata/ahci-platform.txt
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ Required properties:
Optional properties:
- dma-coherent : Present if dma operations are coherent
- clocks : a list of phandle + clock specifier pairs
- target-supply : regulator for SATA target power

Example:
sata@ffe08000 {
Expand Down
2 changes: 2 additions & 0 deletions drivers/ata/ahci.h
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@

#include <linux/clk.h>
#include <linux/libata.h>
#include <linux/regulator/consumer.h>

/* Enclosure Management Control */
#define EM_CTRL_MSG_TYPE 0x000f0000
Expand Down Expand Up @@ -323,6 +324,7 @@ struct ahci_host_priv {
u32 em_buf_sz; /* EM buffer size in byte */
u32 em_msg_type; /* EM message type */
struct clk *clks[AHCI_MAX_CLKS]; /* Optional */
struct regulator *target_pwr; /* Optional */
void *plat_data; /* Other platform data */
/*
* Optional ahci_start_engine override, if not set this gets set to the
Expand Down
36 changes: 34 additions & 2 deletions drivers/ata/ahci_platform.c
Original file line number Diff line number Diff line change
Expand Up @@ -185,6 +185,14 @@ static int ahci_probe(struct platform_device *pdev)
return -ENOMEM;
}

hpriv->target_pwr = devm_regulator_get_optional(dev, "target");
if (IS_ERR(hpriv->target_pwr)) {
rc = PTR_ERR(hpriv->target_pwr);
if (rc == -EPROBE_DEFER)
return -EPROBE_DEFER;
hpriv->target_pwr = NULL;
}

for (i = 0; i < AHCI_MAX_CLKS; i++) {
/*
* For now we must use clk_get(dev, NULL) for the first clock,
Expand All @@ -206,9 +214,15 @@ static int ahci_probe(struct platform_device *pdev)
hpriv->clks[i] = clk;
}

if (hpriv->target_pwr) {
rc = regulator_enable(hpriv->target_pwr);
if (rc)
goto free_clk;
}

rc = ahci_enable_clks(dev, hpriv);
if (rc)
goto free_clk;
goto disable_regulator;

/*
* Some platforms might need to prepare for mmio region access,
Expand Down Expand Up @@ -291,6 +305,9 @@ static int ahci_probe(struct platform_device *pdev)
pdata->exit(dev);
disable_unprepare_clk:
ahci_disable_clks(hpriv);
disable_regulator:
if (hpriv->target_pwr)
regulator_disable(hpriv->target_pwr);
free_clk:
ahci_put_clks(hpriv);
return rc;
Expand All @@ -307,6 +324,9 @@ static void ahci_host_stop(struct ata_host *host)

ahci_disable_clks(hpriv);
ahci_put_clks(hpriv);

if (hpriv->target_pwr)
regulator_disable(hpriv->target_pwr);
}

#ifdef CONFIG_PM_SLEEP
Expand Down Expand Up @@ -343,6 +363,9 @@ static int ahci_suspend(struct device *dev)

ahci_disable_clks(hpriv);

if (hpriv->target_pwr)
regulator_disable(hpriv->target_pwr);

return 0;
}

Expand All @@ -353,9 +376,15 @@ static int ahci_resume(struct device *dev)
struct ahci_host_priv *hpriv = host->private_data;
int rc;

if (hpriv->target_pwr) {
rc = regulator_enable(hpriv->target_pwr);
if (rc)
return rc;
}

rc = ahci_enable_clks(dev, hpriv);
if (rc)
return rc;
goto disable_regulator;

if (pdata && pdata->resume) {
rc = pdata->resume(dev);
Expand All @@ -377,6 +406,9 @@ static int ahci_resume(struct device *dev)

disable_unprepare_clk:
ahci_disable_clks(hpriv);
disable_regulator:
if (hpriv->target_pwr)
regulator_disable(hpriv->target_pwr);

return rc;
}
Expand Down

0 comments on commit 4b3e603

Please sign in to comment.