Skip to content

Commit

Permalink
nfp: call netif_carrier_off() during init
Browse files Browse the repository at this point in the history
Netdevs default to carrier on, we should call netif_carrier_off()
during initialization since we handle carrier state changes in the
driver.

Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Reviewed-by: Rolf Neugebauer <rolf.neugebauer@netronome.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Jakub Kicinski authored and David S. Miller committed Dec 18, 2015
1 parent 6462de8 commit 4b402d7
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions drivers/net/ethernet/netronome/nfp/nfp_net_common.c
Original file line number Diff line number Diff line change
Expand Up @@ -2417,6 +2417,7 @@ int nfp_net_netdev_init(struct net_device *netdev)
ether_setup(netdev);
netdev->netdev_ops = &nfp_net_netdev_ops;
netdev->watchdog_timeo = msecs_to_jiffies(5 * 1000);
netif_carrier_off(netdev);

nfp_net_set_ethtool_ops(netdev);
nfp_net_irqs_assign(netdev);
Expand Down

0 comments on commit 4b402d7

Please sign in to comment.