Skip to content

Commit

Permalink
HID: picoLCD: Deletion of unnecessary checks before three function calls
Browse files Browse the repository at this point in the history
The functions backlight_device_unregister(), lcd_device_unregister() and
rc_unregister_device() test whether their argument is NULL and then
return immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Reviewed-by: Bruno Prémont <bonbons@linux-vserver.org>
Signed-off-by: Jiri Kosina <jkosina@suse.com>
  • Loading branch information
Markus Elfring authored and Jiri Kosina committed Jun 29, 2015
1 parent 67db8a8 commit 4b8a826
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 6 deletions.
3 changes: 1 addition & 2 deletions drivers/hid/hid-picolcd_backlight.c
Original file line number Diff line number Diff line change
Expand Up @@ -94,8 +94,7 @@ void picolcd_exit_backlight(struct picolcd_data *data)
struct backlight_device *bdev = data->backlight;

data->backlight = NULL;
if (bdev)
backlight_device_unregister(bdev);
backlight_device_unregister(bdev);
}

int picolcd_resume_backlight(struct picolcd_data *data)
Expand Down
3 changes: 1 addition & 2 deletions drivers/hid/hid-picolcd_cir.c
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,6 @@ void picolcd_exit_cir(struct picolcd_data *data)
struct rc_dev *rdev = data->rc_dev;

data->rc_dev = NULL;
if (rdev)
rc_unregister_device(rdev);
rc_unregister_device(rdev);
}

3 changes: 1 addition & 2 deletions drivers/hid/hid-picolcd_lcd.c
Original file line number Diff line number Diff line change
Expand Up @@ -92,8 +92,7 @@ void picolcd_exit_lcd(struct picolcd_data *data)
struct lcd_device *ldev = data->lcd;

data->lcd = NULL;
if (ldev)
lcd_device_unregister(ldev);
lcd_device_unregister(ldev);
}

int picolcd_resume_lcd(struct picolcd_data *data)
Expand Down

0 comments on commit 4b8a826

Please sign in to comment.