Skip to content

Commit

Permalink
mtip32xx: use BLK_STS_DEV_RESOURCE for device resources
Browse files Browse the repository at this point in the history
For cases where we can only fail with IO in-flight, we should be using
BLK_STS_DEV_RESOURCE instead of BLK_STS_RESOURCE. The latter refers to
system wide resource constraints.

Signed-off-by: Jens Axboe <axboe@kernel.dk>
  • Loading branch information
Jens Axboe committed Dec 10, 2018
1 parent e4025e4 commit 4ba09f6
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/block/mtip32xx/mtip32xx.c
Original file line number Diff line number Diff line change
Expand Up @@ -3550,7 +3550,7 @@ static blk_status_t mtip_issue_reserved_cmd(struct blk_mq_hw_ctx *hctx,
struct mtip_cmd_sg *command_sg;

if (mtip_commands_active(dd->port))
return BLK_STS_RESOURCE;
return BLK_STS_DEV_RESOURCE;

hdr->ctba = cpu_to_le32(cmd->command_dma & 0xFFFFFFFF);
if (test_bit(MTIP_PF_HOST_CAP_64, &dd->port->flags))
Expand Down Expand Up @@ -3587,7 +3587,7 @@ static blk_status_t mtip_queue_rq(struct blk_mq_hw_ctx *hctx,
return mtip_issue_reserved_cmd(hctx, rq);

if (unlikely(mtip_check_unal_depth(hctx, rq)))
return BLK_STS_RESOURCE;
return BLK_STS_DEV_RESOURCE;

if (is_se_active(dd) || is_stopped(dd, rq))
return BLK_STS_IOERR;
Expand Down

0 comments on commit 4ba09f6

Please sign in to comment.