Skip to content

Commit

Permalink
RAS/CEC: Convert to DEFINE_SHOW_ATTRIBUTE()
Browse files Browse the repository at this point in the history
Use the DEFINE_SHOW_ATTRIBUTE() macro and simplify the code.

Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com>
Signed-off-by: Borislav Petkov <bp@suse.de>
Link: https://lkml.kernel.org/r/20200919012252.171437-1-miaoqinglang@huawei.com
  • Loading branch information
Qinglang Miao authored and Borislav Petkov committed Sep 25, 2020
1 parent e100777 commit 4bd442e
Showing 1 changed file with 3 additions and 14 deletions.
17 changes: 3 additions & 14 deletions drivers/ras/cec.c
Original file line number Diff line number Diff line change
Expand Up @@ -435,7 +435,7 @@ DEFINE_DEBUGFS_ATTRIBUTE(action_threshold_ops, u64_get, action_threshold_set, "%

static const char * const bins[] = { "00", "01", "10", "11" };

static int array_dump(struct seq_file *m, void *v)
static int array_show(struct seq_file *m, void *v)
{
struct ce_array *ca = &ce_arr;
int i;
Expand Down Expand Up @@ -467,18 +467,7 @@ static int array_dump(struct seq_file *m, void *v)
return 0;
}

static int array_open(struct inode *inode, struct file *filp)
{
return single_open(filp, array_dump, NULL);
}

static const struct file_operations array_ops = {
.owner = THIS_MODULE,
.open = array_open,
.read = seq_read,
.llseek = seq_lseek,
.release = single_release,
};
DEFINE_SHOW_ATTRIBUTE(array);

static int __init create_debugfs_nodes(void)
{
Expand Down Expand Up @@ -513,7 +502,7 @@ static int __init create_debugfs_nodes(void)
goto err;
}

array = debugfs_create_file("array", S_IRUSR, d, NULL, &array_ops);
array = debugfs_create_file("array", S_IRUSR, d, NULL, &array_fops);
if (!array) {
pr_warn("Error creating array debugfs node!\n");
goto err;
Expand Down

0 comments on commit 4bd442e

Please sign in to comment.