Skip to content

Commit

Permalink
dm: remove incomplete BLOCK_PC support
Browse files Browse the repository at this point in the history
DM tries to copy a few fields around for BLOCK_PC requests, but given
that no dm-target ever wires up scsi_cmd_ioctl BLOCK_PC can't actually
be sent to dm.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Hannes Reinecke <hare@suse.com>
Signed-off-by: Jens Axboe <axboe@fb.com>
  • Loading branch information
Christoph Hellwig authored and Jens Axboe committed Jan 27, 2017
1 parent 48b77ad commit 4bf5843
Showing 1 changed file with 0 additions and 16 deletions.
16 changes: 0 additions & 16 deletions drivers/md/dm-rq.c
Original file line number Diff line number Diff line change
Expand Up @@ -270,19 +270,6 @@ static void dm_end_request(struct request *clone, int error)
struct mapped_device *md = tio->md;
struct request *rq = tio->orig;

if (rq->cmd_type == REQ_TYPE_BLOCK_PC) {
rq->errors = clone->errors;
rq->resid_len = clone->resid_len;

if (rq->sense)
/*
* We are using the sense buffer of the original
* request.
* So setting the length of the sense data is enough.
*/
rq->sense_len = clone->sense_len;
}

free_rq_clone(clone);
rq_end_stats(md, rq);
if (!rq->q->mq_ops)
Expand Down Expand Up @@ -511,9 +498,6 @@ static int setup_clone(struct request *clone, struct request *rq,
if (r)
return r;

clone->cmd = rq->cmd;
clone->cmd_len = rq->cmd_len;
clone->sense = rq->sense;
clone->end_io = end_clone_request;
clone->end_io_data = tio;

Expand Down

0 comments on commit 4bf5843

Please sign in to comment.