Skip to content

Commit

Permalink
net: core: dst_cache_set_ip6: Rename 'addr' parameter to 'saddr' for …
Browse files Browse the repository at this point in the history
…consistency

The other dst_cache_{get,set}_ip{4,6} functions, and the doc comment for
dst_cache_set_ip6 use 'saddr' for their source address parameter. Rename
the parameter to increase consistency.

This fixes the following kernel-doc warnings:

./include/net/dst_cache.h:58: warning: Function parameter or member 'addr' not described in 'dst_cache_set_ip6'
./include/net/dst_cache.h:58: warning: Excess function parameter 'saddr' description in 'dst_cache_set_ip6'

Fixes: 911362c ("net: add dst_cache support")
Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Jonathan Neuschäfer authored and David S. Miller committed Mar 5, 2018
1 parent 76b1297 commit 4c1342d
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion include/net/dst_cache.h
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ void dst_cache_set_ip4(struct dst_cache *dst_cache, struct dst_entry *dst,
* local BH must be disabled.
*/
void dst_cache_set_ip6(struct dst_cache *dst_cache, struct dst_entry *dst,
const struct in6_addr *addr);
const struct in6_addr *saddr);

/**
* dst_cache_get_ip6 - perform cache lookup and fetch ipv6 source address
Expand Down
4 changes: 2 additions & 2 deletions net/core/dst_cache.c
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ EXPORT_SYMBOL_GPL(dst_cache_set_ip4);

#if IS_ENABLED(CONFIG_IPV6)
void dst_cache_set_ip6(struct dst_cache *dst_cache, struct dst_entry *dst,
const struct in6_addr *addr)
const struct in6_addr *saddr)
{
struct dst_cache_pcpu *idst;

Expand All @@ -117,7 +117,7 @@ void dst_cache_set_ip6(struct dst_cache *dst_cache, struct dst_entry *dst,
idst = this_cpu_ptr(dst_cache->cache);
dst_cache_per_cpu_dst_set(this_cpu_ptr(dst_cache->cache), dst,
rt6_get_cookie((struct rt6_info *)dst));
idst->in6_saddr = *addr;
idst->in6_saddr = *saddr;
}
EXPORT_SYMBOL_GPL(dst_cache_set_ip6);

Expand Down

0 comments on commit 4c1342d

Please sign in to comment.