Skip to content

Commit

Permalink
ipv6: Fix nexthdr for reinjection
Browse files Browse the repository at this point in the history
In ip6_input_finish the nexthdr protocol is retrieved from the
next header offset that is returned in the cb of the skb.
This method does not work for UDP encapsulation that may not
even have a concept of a nexthdr field (e.g. FOU).

This patch checks for a final protocol (INET6_PROTO_FINAL) when a
protocol handler returns > 0. If the protocol is not final then
resubmission is performed on nhoff value. If the protocol is final
then the nexthdr is taken to be the return value.

Signed-off-by: Tom Herbert <tom@herbertland.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Tom Herbert authored and David S. Miller committed May 20, 2016
1 parent 7e13318 commit 4c64242
Showing 1 changed file with 15 additions and 3 deletions.
18 changes: 15 additions & 3 deletions net/ipv6/ip6_input.c
Original file line number Diff line number Diff line change
@@ -236,6 +236,7 @@ static int ip6_input_finish(struct net *net, struct sock *sk, struct sk_buff *sk
nhoff = IP6CB(skb)->nhoff;
nexthdr = skb_network_header(skb)[nhoff];

resubmit_final:
raw = raw6_local_deliver(skb, nexthdr);
ipprot = rcu_dereference(inet6_protos[nexthdr]);
if (ipprot) {
@@ -263,10 +264,21 @@ static int ip6_input_finish(struct net *net, struct sock *sk, struct sk_buff *sk
goto discard;

ret = ipprot->handler(skb);
if (ret > 0)
goto resubmit;
else if (ret == 0)
if (ret > 0) {
if (ipprot->flags & INET6_PROTO_FINAL) {
/* Not an extension header, most likely UDP
* encapsulation. Use return value as nexthdr
* protocol not nhoff (which presumably is
* not set by handler).
*/
nexthdr = ret;
goto resubmit_final;
} else {
goto resubmit;
}
} else if (ret == 0) {
__IP6_INC_STATS(net, idev, IPSTATS_MIB_INDELIVERS);
}
} else {
if (!raw) {
if (xfrm6_policy_check(NULL, XFRM_POLICY_IN, skb)) {

0 comments on commit 4c64242

Please sign in to comment.