Skip to content

Commit

Permalink
OMAPDSS: DISPC: fix loop in error handler
Browse files Browse the repository at this point in the history
The dispc's error handler has a loop inside another loop, and both use
the same loop variable. This is clearly wrong, and this patch makes a
new variable for the inner loop.

Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
  • Loading branch information
Tomi Valkeinen committed Oct 29, 2012
1 parent 901e5fe commit 4c6c65b
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions drivers/video/omap2/dss/dispc.c
Original file line number Diff line number Diff line change
Expand Up @@ -3901,6 +3901,7 @@ static void dispc_error_worker(struct work_struct *work)
bit = mgr_desc[i].sync_lost_irq;

if (bit & errors) {
int j;
struct omap_dss_device *dssdev = mgr->get_device(mgr);
bool enable;

Expand All @@ -3911,9 +3912,9 @@ static void dispc_error_worker(struct work_struct *work)
enable = dssdev->state == OMAP_DSS_DISPLAY_ACTIVE;
dssdev->driver->disable(dssdev);

for (i = 0; i < omap_dss_get_num_overlays(); ++i) {
for (j = 0; j < omap_dss_get_num_overlays(); ++j) {
struct omap_overlay *ovl;
ovl = omap_dss_get_overlay(i);
ovl = omap_dss_get_overlay(j);

if (ovl->id != OMAP_DSS_GFX &&
ovl->manager == mgr)
Expand Down

0 comments on commit 4c6c65b

Please sign in to comment.