Skip to content

Commit

Permalink
Merge branch 'for-linus' of git://oss.sgi.com/xfs/xfs
Browse files Browse the repository at this point in the history
* 'for-linus' of git://oss.sgi.com/xfs/xfs:
  xfs: zero proper structure size for geometry calls
  • Loading branch information
Linus Torvalds committed Mar 3, 2011
2 parents c640e13 + af24ee9 commit 4c7fd11
Showing 1 changed file with 8 additions and 3 deletions.
11 changes: 8 additions & 3 deletions fs/xfs/linux-2.6/xfs_ioctl.c
Original file line number Diff line number Diff line change
Expand Up @@ -695,14 +695,19 @@ xfs_ioc_fsgeometry_v1(
xfs_mount_t *mp,
void __user *arg)
{
xfs_fsop_geom_v1_t fsgeo;
xfs_fsop_geom_t fsgeo;
int error;

error = xfs_fs_geometry(mp, (xfs_fsop_geom_t *)&fsgeo, 3);
error = xfs_fs_geometry(mp, &fsgeo, 3);
if (error)
return -error;

if (copy_to_user(arg, &fsgeo, sizeof(fsgeo)))
/*
* Caller should have passed an argument of type
* xfs_fsop_geom_v1_t. This is a proper subset of the
* xfs_fsop_geom_t that xfs_fs_geometry() fills in.
*/
if (copy_to_user(arg, &fsgeo, sizeof(xfs_fsop_geom_v1_t)))
return -XFS_ERROR(EFAULT);
return 0;
}
Expand Down

0 comments on commit 4c7fd11

Please sign in to comment.