Skip to content

Commit

Permalink
bus: omap_l3_noc: Correct returning IRQ_HANDLED unconditionally in th…
Browse files Browse the repository at this point in the history
…e irq handler

commit c4cf093 upstream.

Correct returning IRQ_HANDLED unconditionally in the irq handler.
Return IRQ_NONE for some interrupt which we do not expect to be
handled in this handler. This prevents kernel stalling with back
to back spurious interrupts.

Fixes: 2722e56 ("OMAP4: l3: Introduce l3-interconnect error handling driver")
Acked-by: Nishanth Menon <nm@ti.com>
Signed-off-by: Keerthy <j-keerthy@ti.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Keerthy authored and Greg Kroah-Hartman committed Jan 27, 2015
1 parent 397ee66 commit 4cb194f
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions drivers/bus/omap_l3_noc.c
Original file line number Diff line number Diff line change
Expand Up @@ -222,10 +222,14 @@ static irqreturn_t l3_interrupt_handler(int irq, void *_l3)
}

/* Error found so break the for loop */
break;
return IRQ_HANDLED;
}
}
return IRQ_HANDLED;

dev_err(l3->dev, "L3 %s IRQ not handled!!\n",
inttype ? "debug" : "application");

return IRQ_NONE;
}

static const struct of_device_id l3_noc_match[] = {
Expand Down

0 comments on commit 4cb194f

Please sign in to comment.