Skip to content

Commit

Permalink
mmc: sdhci-xenon: Fix the work flow in xenon_remove().
Browse files Browse the repository at this point in the history
sdhci_remove_host() might execute SOFT_RESET_ALL.  Inside xenon_remove(),
Xenon SDHC should be enabled during sdhci_remove_host().

Move xenon_sdhc_unprepare after sdhci_remove_host() such that Xenon SDHC is
disabled after sdhci_remove_host() completes.

Signed-off-by: Hu Ziji <huziji@marvell.com>
Reported-by: Jisheng Zhang <jszhang@marvell.com>
Tested-by: Jisheng Zhang <jszhang@marvell.com>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
  • Loading branch information
Hu Ziji authored and Ulf Hansson committed Apr 28, 2017
1 parent ff4143c commit 4cc59df
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/mmc/host/sdhci-xenon.c
Original file line number Diff line number Diff line change
Expand Up @@ -512,10 +512,10 @@ static int xenon_remove(struct platform_device *pdev)

xenon_clean_phy(host);

xenon_sdhc_unprepare(host);

sdhci_remove_host(host, 0);

xenon_sdhc_unprepare(host);

clk_disable_unprepare(pltfm_host->clk);

sdhci_pltfm_free(pdev);
Expand Down

0 comments on commit 4cc59df

Please sign in to comment.