Skip to content

Commit

Permalink
ASoC: ops: Reject out of bounds values in snd_soc_put_xr_sx()
Browse files Browse the repository at this point in the history
We don't currently validate that the values being set are within the range
we advertised to userspace as being valid, do so and reject any values
that are out of range.

Signed-off-by: Mark Brown <broonie@kernel.org>
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/20220124153253.3548853-4-broonie@kernel.org
Signed-off-by: Mark Brown <broonie@kernel.org>
  • Loading branch information
Mark Brown committed Jan 25, 2022
1 parent 4f1e50d commit 4cf28e9
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions sound/soc/soc-ops.c
Original file line number Diff line number Diff line change
Expand Up @@ -879,6 +879,8 @@ int snd_soc_put_xr_sx(struct snd_kcontrol *kcontrol,
long val = ucontrol->value.integer.value[0];
unsigned int i;

if (val < mc->min || val > mc->max)
return -EINVAL;
if (invert)
val = max - val;
val &= mask;
Expand Down

0 comments on commit 4cf28e9

Please sign in to comment.