Skip to content

Commit

Permalink
media: ti-vpe: cal: Use ARRAY_SIZE to replace numerical value
Browse files Browse the repository at this point in the history
Use ARRAY_SIZE(cal->ctx) to iterate over the cal->ctx array instead of
using the numerical value from the CAL_NUM_CONTEXT macro (or, worse,
hardcoding the value 2). This will allow reworking contexts with less
changes in the code.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Benoit Parrot <bparrot@ti.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
  • Loading branch information
Laurent Pinchart authored and Mauro Carvalho Chehab committed Jul 19, 2020
1 parent f5ddf19 commit 4d04c23
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions drivers/media/platform/ti-vpe/cal.c
Original file line number Diff line number Diff line change
Expand Up @@ -1314,7 +1314,7 @@ static irqreturn_t cal_irq(int irq_cal, void *data)
/* Clear Interrupt status */
reg_write(cal, CAL_HL_IRQSTATUS(1), status);

for (i = 0; i < 2; ++i) {
for (i = 0; i < ARRAY_SIZE(cal->ctx); ++i) {
if (isportirqset(status, i)) {
ctx = cal->ctx[i];

Expand All @@ -1337,7 +1337,7 @@ static irqreturn_t cal_irq(int irq_cal, void *data)
/* Clear Interrupt status */
reg_write(cal, CAL_HL_IRQSTATUS(2), status);

for (i = 0; i < 2; ++i) {
for (i = 0; i < ARRAY_SIZE(cal->ctx); ++i) {
if (isportirqset(status, i)) {
ctx = cal->ctx[i];
dma_q = &ctx->vidq;
Expand Down Expand Up @@ -2345,7 +2345,7 @@ static int cal_probe(struct platform_device *pdev)
pm_runtime_disable(&pdev->dev);

error_context:
for (i = 0; i < CAL_NUM_CONTEXT; i++) {
for (i = 0; i < ARRAY_SIZE(cal->ctx); i++) {
ctx = cal->ctx[i];
if (ctx) {
v4l2_async_notifier_unregister(&ctx->notifier);
Expand Down Expand Up @@ -2373,7 +2373,7 @@ static int cal_remove(struct platform_device *pdev)

pm_runtime_get_sync(&pdev->dev);

for (i = 0; i < CAL_NUM_CONTEXT; i++) {
for (i = 0; i < ARRAY_SIZE(cal->ctx); i++) {
ctx = cal->ctx[i];
if (ctx) {
ctx_dbg(1, ctx, "unregistering %s\n",
Expand Down

0 comments on commit 4d04c23

Please sign in to comment.