Skip to content

Commit

Permalink
selftests: mlxsw: Adjust test to recent changes
Browse files Browse the repository at this point in the history
mlxsw does not support VXLAN devices with a physical device attached and
vetoes such configurations upon enslavement to an offloaded bridge.

Commit 0ce1822 ("vxlan: add adjacent link to limit depth level")
changed the VXLAN device to be an upper of the physical device which
causes mlxsw to veto the creation of the VXLAN device with "Unknown
upper device type".

This is OK as this configuration is not supported, but it prevents us
from testing bad flows involving the enslavement of VXLAN devices with a
physical device to a bridge, regardless if the physical device is an
mlxsw netdev or not.

Adjust the test to use a dummy device as a physical device instead of a
mlxsw netdev.

Fixes: 0ce1822 ("vxlan: add adjacent link to limit depth level")
Signed-off-by: Ido Schimmel <idosch@mellanox.com>
Acked-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Ido Schimmel authored and David S. Miller committed Nov 15, 2019
1 parent 4a92e53 commit 4d189c1
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions tools/testing/selftests/drivers/net/mlxsw/vxlan.sh
Original file line number Diff line number Diff line change
Expand Up @@ -112,14 +112,16 @@ sanitization_single_dev_mcast_group_test()
RET=0

ip link add dev br0 type bridge mcast_snooping 0
ip link add name dummy1 up type dummy

ip link add name vxlan0 up type vxlan id 10 nolearning noudpcsum \
ttl 20 tos inherit local 198.51.100.1 dstport 4789 \
dev $swp2 group 239.0.0.1
dev dummy1 group 239.0.0.1

sanitization_single_dev_test_fail

ip link del dev vxlan0
ip link del dev dummy1
ip link del dev br0

log_test "vxlan device with a multicast group"
Expand Down Expand Up @@ -181,13 +183,15 @@ sanitization_single_dev_local_interface_test()
RET=0

ip link add dev br0 type bridge mcast_snooping 0
ip link add name dummy1 up type dummy

ip link add name vxlan0 up type vxlan id 10 nolearning noudpcsum \
ttl 20 tos inherit local 198.51.100.1 dstport 4789 dev $swp2
ttl 20 tos inherit local 198.51.100.1 dstport 4789 dev dummy1

sanitization_single_dev_test_fail

ip link del dev vxlan0
ip link del dev dummy1
ip link del dev br0

log_test "vxlan device with local interface"
Expand Down

0 comments on commit 4d189c1

Please sign in to comment.