Skip to content

Commit

Permalink
HID: lg-g15: make a const array static, makes object smaller
Browse files Browse the repository at this point in the history
Don't populate the const array led_names on the stack but instead make
it static. Makes the object code smaller by 79 bytes:

Before:
   text	   data	    bss	    dec	    hex	filename
  19686	   7952	    256	  27894	   6cf6	drivers/hid/hid-lg-g15.o

After:
   text	   data	    bss	    dec	    hex	filename
  19543	   8016	    256	  27815	   6ca7	drivers/hid/hid-lg-g15.o

(gcc version 10.2.0)

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
  • Loading branch information
Colin Ian King authored and Jiri Kosina committed Feb 5, 2021
1 parent e037acf commit 4d30083
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/hid/hid-lg-g15.c
Original file line number Diff line number Diff line change
Expand Up @@ -647,7 +647,7 @@ static void lg_g15_input_close(struct input_dev *dev)

static int lg_g15_register_led(struct lg_g15_data *g15, int i)
{
const char * const led_names[] = {
static const char * const led_names[] = {
"g15::kbd_backlight",
"g15::lcd_backlight",
"g15::macro_preset1",
Expand Down

0 comments on commit 4d30083

Please sign in to comment.