Skip to content

Commit

Permalink
powerpc: Replace cpu_up/down() with add/remove_cpu()
Browse files Browse the repository at this point in the history
The core device API performs extra housekeeping bits that are missing
from directly calling cpu_up/down.

See commit a6717c0 ("powerpc/rtas: use device model APIs and
serialization during LPM") for an example description of what might go
wrong.

This also prepares to make cpu_up/down() a private interface of the CPU
subsystem.

Signed-off-by: Qais Yousef <qais.yousef@arm.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Acked-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lkml.kernel.org/r/20200323135110.30522-11-qais.yousef@arm.com
  • Loading branch information
Qais Yousef authored and Thomas Gleixner committed Mar 25, 2020
1 parent af7aa04 commit 4d37cc2
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion arch/powerpc/kexec/core_64.c
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ static void wake_offline_cpus(void)
if (!cpu_online(cpu)) {
printk(KERN_INFO "kexec: Waking offline cpu %d.\n",
cpu);
WARN_ON(cpu_up(cpu));
WARN_ON(add_cpu(cpu));
}
}
}
Expand Down

0 comments on commit 4d37cc2

Please sign in to comment.