Skip to content

Commit

Permalink
ALSA: seq: Fix CONFIG_SND_SEQ_MIDI dependency
Browse files Browse the repository at this point in the history
The commit 0181307 ("ALSA: seq: Reorganize kconfig and build")
rewrote the dependency of each sequencer module in a standard way, but
there was one change applied mistakenly: CONFIG_SND_SEQ_MIDI isn't
enabled properly by CONFIG_SND_RAWMIDI.  I seem to have changed the
wrong one instead, CONFIG_SND_SEQ_MIDI_EMUL, which is eventually
reverse-selected by CONFIG_SND_SEQ_MIDI itself.  This ended up the
lack of snd-seq-midi module as reported below.

The fix is to put def_tristate properly to CONFIG_SND_SEQ_MIDI instead
of *_MIDI_EMUL entry.

Fixes: 0181307 ("ALSA: seq: Reorganize kconfig and build")
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=196633
Signed-off-by: Takashi Iwai <tiwai@suse.de>
  • Loading branch information
Takashi Iwai committed Aug 11, 2017
1 parent 5ef26e9 commit 4d3a869
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions sound/core/seq/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -47,10 +47,10 @@ config SND_SEQ_HRTIMER_DEFAULT
timer.

config SND_SEQ_MIDI_EVENT
def_tristate SND_RAWMIDI
tristate

config SND_SEQ_MIDI
tristate
def_tristate SND_RAWMIDI
select SND_SEQ_MIDI_EVENT

config SND_SEQ_MIDI_EMUL
Expand Down

0 comments on commit 4d3a869

Please sign in to comment.