Skip to content

Commit

Permalink
drm: rcar-du: Fix the return value in case of error in 'rcar_du_crtc_…
Browse files Browse the repository at this point in the history
…set_crc_source()'

We return 0 unconditionally in 'rcar_du_crtc_set_crc_source()'.
However, 'ret' is set to some error codes if some function calls fail.

Return 'ret' instead to propagate the error code.

Fixes: 47a52d0 ("media: drm: rcar-du: Add support for CRC computation")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
  • Loading branch information
Christophe JAILLET authored and Laurent Pinchart committed Nov 23, 2018
1 parent 5dc34af commit 4d486f1
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/gpu/drm/rcar-du/rcar_du_crtc.c
Original file line number Diff line number Diff line change
Expand Up @@ -1002,7 +1002,7 @@ static int rcar_du_crtc_set_crc_source(struct drm_crtc *crtc,
drm_modeset_drop_locks(&ctx);
drm_modeset_acquire_fini(&ctx);

return 0;
return ret;
}

static const struct drm_crtc_funcs crtc_funcs_gen2 = {
Expand Down

0 comments on commit 4d486f1

Please sign in to comment.