Skip to content

Commit

Permalink
net: usb: log errors to dmesg/syslog
Browse files Browse the repository at this point in the history
Errors in protocol should be logged when the driver aborts operations.
If the driver can carry on and "humor" the device, then emitting
the message as debug output level is fine.

Signed-off-by: Grant Grundler <grundler@chromium.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Grant Grundler authored and David S. Miller committed Mar 8, 2021
1 parent 492bbe7 commit 4d8c79b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/net/usb/usbnet.c
Original file line number Diff line number Diff line change
Expand Up @@ -887,7 +887,7 @@ int usbnet_open (struct net_device *net)

// insist peer be connected
if (info->check_connect && (retval = info->check_connect (dev)) < 0) {
netif_dbg(dev, ifup, dev->net, "can't open; %d\n", retval);
netif_err(dev, ifup, dev->net, "can't open; %d\n", retval);
goto done;
}

Expand Down

0 comments on commit 4d8c79b

Please sign in to comment.