Skip to content

Commit

Permalink
Remove low_latency flag setting from nozomi and mxser drivers
Browse files Browse the repository at this point in the history
The kernel oopses if this flag is set.

[and neither driver should set it as they call tty_flip_buffer_push from IRQ
 paths so have always been buggy]

Signed-off-by: Chuck Ebbert <cebbert@redhat.com>
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Chuck Ebbert authored and Linus Torvalds committed Jun 24, 2009
1 parent 6af9a43 commit 4d8d4d2
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 4 deletions.
2 changes: 0 additions & 2 deletions drivers/char/mxser.c
Original file line number Diff line number Diff line change
Expand Up @@ -1048,8 +1048,6 @@ static int mxser_open(struct tty_struct *tty, struct file *filp)
if (retval)
return retval;

/* unmark here for very high baud rate (ex. 921600 bps) used */
tty->low_latency = 1;
return 0;
}

Expand Down
2 changes: 0 additions & 2 deletions drivers/char/nozomi.c
Original file line number Diff line number Diff line change
Expand Up @@ -1591,8 +1591,6 @@ static int ntty_open(struct tty_struct *tty, struct file *file)

/* Enable interrupt downlink for channel */
if (port->port.count == 1) {
/* FIXME: is this needed now ? */
tty->low_latency = 1;
tty->driver_data = port;
tty_port_tty_set(&port->port, tty);
DBG1("open: %d", port->token_dl);
Expand Down

0 comments on commit 4d8d4d2

Please sign in to comment.