Skip to content

Commit

Permalink
selftests: mptcp: simult flows: fix some subtest names
Browse files Browse the repository at this point in the history
The selftest was correctly recording all the results, but the 'reverse
direction' part was missing in the name when needed.

It is important to have a unique (sub)test name in TAP, because some CI
environments drop tests with duplicated name.

Fixes: 675d993 ("selftests: mptcp: simult flows: format subtests results in TAP")
Cc: stable@vger.kernel.org
Reviewed-by: Geliang Tang <geliang@kernel.org>
Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Matthieu Baerts (NGI0) authored and David S. Miller committed Feb 18, 2024
1 parent 694bd45 commit 4d8e0dd
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion tools/testing/selftests/net/mptcp/simult_flows.sh
Original file line number Diff line number Diff line change
Expand Up @@ -250,7 +250,8 @@ run_test()
[ $bail -eq 0 ] || exit $ret
fi

printf "%-60s" "$msg - reverse direction"
msg+=" - reverse direction"
printf "%-60s" "${msg}"
do_transfer $large $small $time
lret=$?
mptcp_lib_result_code "${lret}" "${msg}"
Expand Down

0 comments on commit 4d8e0dd

Please sign in to comment.