Skip to content

Commit

Permalink
tmpfs: fix XATTR N overriding POSIX_ACL Y
Browse files Browse the repository at this point in the history
Choosing TMPFS_XATTR default N was switching off TMPFS_POSIX_ACL,
even if it had been Y in oldconfig; and Linus reports that PulseAudio
goes subtly wrong unless it can use ACLs on /dev/shm.

Make TMPFS_POSIX_ACL select TMPFS_XATTR (and depend upon TMPFS),
and move the TMPFS_POSIX_ACL entry before the TMPFS_XATTR entry,
to avoid asking unnecessary questions then ignoring their answers.

Signed-off-by: Hugh Dickins <hughd@google.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Eric Paris authored and Linus Torvalds committed May 26, 2011
1 parent 520fd84 commit 4db70f7
Showing 1 changed file with 15 additions and 14 deletions.
29 changes: 15 additions & 14 deletions fs/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,20 @@ config TMPFS

See <file:Documentation/filesystems/tmpfs.txt> for details.

config TMPFS_POSIX_ACL
bool "Tmpfs POSIX Access Control Lists"
depends on TMPFS
select TMPFS_XATTR
select GENERIC_ACL
help
POSIX Access Control Lists (ACLs) support permissions for users and
groups beyond the owner/group/world scheme.

To learn more about Access Control Lists, visit the POSIX ACLs for
Linux website <http://acl.bestbits.at/>.

If you don't know what Access Control Lists are, say N.

config TMPFS_XATTR
bool "Tmpfs extended attributes"
depends on TMPFS
Expand All @@ -133,22 +147,9 @@ config TMPFS_XATTR
Currently this enables support for the trusted.* and
security.* namespaces.

If unsure, say N.

You need this for POSIX ACL support on tmpfs.

config TMPFS_POSIX_ACL
bool "Tmpfs POSIX Access Control Lists"
depends on TMPFS_XATTR
select GENERIC_ACL
help
POSIX Access Control Lists (ACLs) support permissions for users and
groups beyond the owner/group/world scheme.

To learn more about Access Control Lists, visit the POSIX ACLs for
Linux website <http://acl.bestbits.at/>.

If you don't know what Access Control Lists are, say N.
If unsure, say N.

config HUGETLBFS
bool "HugeTLB file system support"
Expand Down

0 comments on commit 4db70f7

Please sign in to comment.