Skip to content

Commit

Permalink
drm/i915/bios: add missing __packed to structs used for reading vbt
Browse files Browse the repository at this point in the history
This does not seem to make a difference for the structs in question, but
document the intent.

v2: also pack union child_device_config (Daniel)

Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
  • Loading branch information
Jani Nikula authored and Daniel Vetter committed Sep 19, 2014
1 parent 7cd512f commit 4dc4927
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions drivers/gpu/drm/i915/intel_bios.h
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ struct bdb_header {
u16 version; /**< decimal */
u16 header_size; /**< in bytes */
u16 bdb_size; /**< in bytes */
};
} __packed;

/* strictly speaking, this is a "skip" block, but it has interesting info */
struct vbios_data {
Expand Down Expand Up @@ -252,7 +252,7 @@ union child_device_config {
/* This one should also be safe to use anywhere, even without version
* checks. */
struct common_child_dev_config common;
};
} __packed;

struct bdb_general_definitions {
/* DDC GPIO */
Expand Down Expand Up @@ -888,12 +888,12 @@ struct mipi_pps_data {
u16 bl_disable_delay;
u16 panel_off_delay;
u16 panel_power_cycle_delay;
};
} __packed;

struct bdb_mipi_config {
struct mipi_config config[MAX_MIPI_CONFIGURATIONS];
struct mipi_pps_data pps[MAX_MIPI_CONFIGURATIONS];
};
} __packed;

/* Block 53 contains MIPI sequences as needed by the panel
* for enabling it. This block can be variable in size and
Expand All @@ -902,7 +902,7 @@ struct bdb_mipi_config {
struct bdb_mipi_sequence {
u8 version;
u8 data[0];
};
} __packed;

/* MIPI Sequnece Block definitions */
enum mipi_seq {
Expand Down

0 comments on commit 4dc4927

Please sign in to comment.