Skip to content

Commit

Permalink
ALSA: control: remove entry limitation for list operation
Browse files Browse the repository at this point in the history
In current implementation of ALSA control core, list operation has
a limitation to handle 16384 entries at once. This seems due to
allocation in kernel space to copy data from user space.

With a commit 53e7bf4 ("ALSA: control: Simplify snd_ctl_elem_list()
implementation"), for the operation, ALSA control core copies data
into user space directly. No need to care of kernel spaces anymore.

This commit purges the limitation.

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
  • Loading branch information
Takashi Sakamoto authored and Takashi Iwai committed May 24, 2017
1 parent ffb73b0 commit 4e361d3
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions sound/core/control.c
Original file line number Diff line number Diff line change
Expand Up @@ -757,9 +757,7 @@ static int snd_ctl_elem_list(struct snd_card *card,
return -EFAULT;
offset = list.offset;
space = list.space;
/* try limit maximum space */
if (space > 16384)
return -ENOMEM;

down_read(&card->controls_rwsem);
list.count = card->controls_count;
list.used = 0;
Expand Down

0 comments on commit 4e361d3

Please sign in to comment.