Skip to content

Commit

Permalink
drm/bridge: ti-sn65dsi86: Reorder remove()
Browse files Browse the repository at this point in the history
Let's make the remove() function strictly the reverse of the probe()
function so it's easier to reason about.

This patch was created by code inspection and should move us closer to
a proper remove.

Signed-off-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Andrzej Hajda <a.hajda@samsung.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20210416153909.v4.4.Ifcf1deaa372eba7eeb4f8eb516c5d15b77a657a9@changeid
  • Loading branch information
Douglas Anderson committed Apr 20, 2021
1 parent 6b7adae commit 4e53286
Showing 1 changed file with 8 additions and 7 deletions.
15 changes: 8 additions & 7 deletions drivers/gpu/drm/bridge/ti-sn65dsi86.c
Original file line number Diff line number Diff line change
Expand Up @@ -1315,20 +1315,21 @@ static int ti_sn_bridge_remove(struct i2c_client *client)
if (!pdata)
return -EINVAL;

kfree(pdata->edid);
ti_sn_debugfs_remove(pdata);

of_node_put(pdata->host_node);

pm_runtime_disable(pdata->dev);

if (pdata->dsi) {
mipi_dsi_detach(pdata->dsi);
mipi_dsi_device_unregister(pdata->dsi);
}

kfree(pdata->edid);

ti_sn_debugfs_remove(pdata);

drm_bridge_remove(&pdata->bridge);

pm_runtime_disable(pdata->dev);

of_node_put(pdata->host_node);

return 0;
}

Expand Down

0 comments on commit 4e53286

Please sign in to comment.