Skip to content

Commit

Permalink
infiniband: i40iw: Replace GFP_ATOMIC with GFP_KERNEL in i40iw_l2para…
Browse files Browse the repository at this point in the history
…m_change

i40iw_l2param_change() is never called in atomic context.

i40iw_make_listen_node() is only set as ".l2_param_change"
in struct i40e_client_ops, and this function pointer is not called
in atomic context.

Despite never getting called from atomic context,
i40iw_l2param_change() calls kzalloc() with GFP_ATOMIC,
which does not sleep for allocation.
GFP_ATOMIC is not necessary and can be replaced with GFP_KERNEL,
which can sleep and improve the possibility of sucessful allocation.

This is found by a static analysis tool named DCNS written by myself.
And I also manually check it.

Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Acked-by: Shiraz Saleem <shiraz.saleem@intel.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
  • Loading branch information
Jia-Ju Bai authored and Jason Gunthorpe committed Apr 18, 2018
1 parent f9af873 commit 4e56569
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/infiniband/hw/i40iw/i40iw_main.c
Original file line number Diff line number Diff line change
Expand Up @@ -1758,7 +1758,7 @@ static void i40iw_l2param_change(struct i40e_info *ldev, struct i40e_client *cli
return;


work = kzalloc(sizeof(*work), GFP_ATOMIC);
work = kzalloc(sizeof(*work), GFP_KERNEL);
if (!work)
return;

Expand Down

0 comments on commit 4e56569

Please sign in to comment.