Skip to content

Commit

Permalink
tty: serial: linflexuart: Fix to check return value of platform_get_i…
Browse files Browse the repository at this point in the history
…rq() in linflex_probe()

The platform_get_irq might be failed and return a negative result. So
there should have an error handling code.

Fixed this by adding an error handling code.

Signed-off-by: Zhang Shurong <zhang_shurong@foxmail.com>
Link: https://lore.kernel.org/r/tencent_234B0AACD06350E10D7548C2E086A9166305@qq.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Zhang Shurong authored and Greg Kroah-Hartman committed Sep 18, 2023
1 parent 66ebe67 commit 4e8da86
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion drivers/tty/serial/fsl_linflexuart.c
Original file line number Diff line number Diff line change
Expand Up @@ -832,10 +832,14 @@ static int linflex_probe(struct platform_device *pdev)
return PTR_ERR(sport->membase);
sport->mapbase = res->start;

ret = platform_get_irq(pdev, 0);
if (ret < 0)
return ret;

sport->dev = &pdev->dev;
sport->type = PORT_LINFLEXUART;
sport->iotype = UPIO_MEM;
sport->irq = platform_get_irq(pdev, 0);
sport->irq = ret;
sport->ops = &linflex_pops;
sport->flags = UPF_BOOT_AUTOCONF;
sport->has_sysrq = IS_ENABLED(CONFIG_SERIAL_FSL_LINFLEXUART_CONSOLE);
Expand Down

0 comments on commit 4e8da86

Please sign in to comment.