Skip to content

Commit

Permalink
mm: double mark_page_accessed() in read_cache_page_async()
Browse files Browse the repository at this point in the history
Fix a post-2.6.21 regression.

read_cache_page_async() has two invocations of mark_page_accessed() which will
launch pages right onto the active list.

Remove the first one, keeping the latter one.  This avoids marking unwanted
pages active (in the retry loop).

Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Acked-by: Nick Piggin <nickpiggin@yahoo.com.au>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Peter Zijlstra authored and Linus Torvalds committed Jul 8, 2007
1 parent 95511ad commit 4e99325
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion mm/filemap.c
Original file line number Diff line number Diff line change
Expand Up @@ -1786,7 +1786,6 @@ struct page *read_cache_page_async(struct address_space *mapping,
page = __read_cache_page(mapping, index, filler, data);
if (IS_ERR(page))
return page;
mark_page_accessed(page);
if (PageUptodate(page))
goto out;

Expand Down

0 comments on commit 4e99325

Please sign in to comment.