Skip to content

Commit

Permalink
serial: efm32: use $vendor,$device scheme for compatible string
Browse files Browse the repository at this point in the history
Wolfram Sang pointed out that "efm32,$device" is non-standard. So use the
common scheme and prefix device with "efm32-". The old compatible string
is left in place until arch/arm/boot/dts/efm32* is fixed.

Reported-by: Wolfram Sang <wsa@the-dreams.de>
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: Wolfram Sang <wsa@the-dreams.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Uwe Kleine-König authored and Greg Kroah-Hartman committed Apr 16, 2014
1 parent 93a2e47 commit 4ea8daf
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
4 changes: 2 additions & 2 deletions Documentation/devicetree/bindings/serial/efm32-uart.txt
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
* Energymicro efm32 UART

Required properties:
- compatible : Should be "efm32,uart"
- compatible : Should be "energymicro,efm32-uart"
- reg : Address and length of the register set
- interrupts : Should contain uart interrupt

Expand All @@ -13,7 +13,7 @@ Optional properties:
Example:

uart@0x4000c400 {
compatible = "efm32,uart";
compatible = "energymicro,efm32-uart";
reg = <0x4000c400 0x400>;
interrupts = <15>;
efm32,location = <0>;
Expand Down
3 changes: 3 additions & 0 deletions drivers/tty/serial/efm32-uart.c
Original file line number Diff line number Diff line change
Expand Up @@ -798,6 +798,9 @@ static int efm32_uart_remove(struct platform_device *pdev)

static const struct of_device_id efm32_uart_dt_ids[] = {
{
.compatible = "energymicro,efm32-uart",
}, {
/* doesn't follow the "vendor,device" scheme, don't use */
.compatible = "efm32,uart",
}, {
/* sentinel */
Expand Down

0 comments on commit 4ea8daf

Please sign in to comment.