Skip to content

Commit

Permalink
net: ethernet: sun: remove redundant variables adv and lpa and mii_reads
Browse files Browse the repository at this point in the history
Variables adv and lpa are being assigned but are never used hence they
are redundant and can be removed.  Also remove the unncessary mii_reads
too.

Cleans up clang warnings:
warning: variable 'lpa' set but not used [-Wunused-but-set-variable]
warning: variable 'adv' set but not used [-Wunused-but-set-variable]

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Colin Ian King authored and David S. Miller committed Jul 5, 2018
1 parent 2727eac commit 4ed88df
Showing 1 changed file with 0 additions and 16 deletions.
16 changes: 0 additions & 16 deletions drivers/net/ethernet/sun/niu.c
Original file line number Diff line number Diff line change
Expand Up @@ -1225,25 +1225,9 @@ static int link_status_1g_rgmii(struct niu *np, int *link_up_p)

bmsr = err;
if (bmsr & BMSR_LSTATUS) {
u16 adv, lpa;

err = mii_read(np, np->phy_addr, MII_ADVERTISE);
if (err < 0)
goto out;
adv = err;

err = mii_read(np, np->phy_addr, MII_LPA);
if (err < 0)
goto out;
lpa = err;

err = mii_read(np, np->phy_addr, MII_ESTATUS);
if (err < 0)
goto out;
link_up = 1;
current_speed = SPEED_1000;
current_duplex = DUPLEX_FULL;

}
lp->active_speed = current_speed;
lp->active_duplex = current_duplex;
Expand Down

0 comments on commit 4ed88df

Please sign in to comment.