Skip to content

Commit

Permalink
crypto: zip - remove the unneeded result variable
Browse files Browse the repository at this point in the history
Return the value directly instead of storing it in another redundant
variable.

Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
  • Loading branch information
ye xingchen authored and Herbert Xu committed Sep 30, 2022
1 parent 72f6e0e commit 4edff84
Showing 1 changed file with 6 additions and 24 deletions.
30 changes: 6 additions & 24 deletions drivers/crypto/cavium/zip/zip_crypto.c
Original file line number Diff line number Diff line change
Expand Up @@ -198,22 +198,16 @@ static int zip_decompress(const u8 *src, unsigned int slen,
/* Legacy Compress framework start */
int zip_alloc_comp_ctx_deflate(struct crypto_tfm *tfm)
{
int ret;
struct zip_kernel_ctx *zip_ctx = crypto_tfm_ctx(tfm);

ret = zip_ctx_init(zip_ctx, 0);

return ret;
return zip_ctx_init(zip_ctx, 0);
}

int zip_alloc_comp_ctx_lzs(struct crypto_tfm *tfm)
{
int ret;
struct zip_kernel_ctx *zip_ctx = crypto_tfm_ctx(tfm);

ret = zip_ctx_init(zip_ctx, 1);

return ret;
return zip_ctx_init(zip_ctx, 1);
}

void zip_free_comp_ctx(struct crypto_tfm *tfm)
Expand All @@ -227,24 +221,18 @@ int zip_comp_compress(struct crypto_tfm *tfm,
const u8 *src, unsigned int slen,
u8 *dst, unsigned int *dlen)
{
int ret;
struct zip_kernel_ctx *zip_ctx = crypto_tfm_ctx(tfm);

ret = zip_compress(src, slen, dst, dlen, zip_ctx);

return ret;
return zip_compress(src, slen, dst, dlen, zip_ctx);
}

int zip_comp_decompress(struct crypto_tfm *tfm,
const u8 *src, unsigned int slen,
u8 *dst, unsigned int *dlen)
{
int ret;
struct zip_kernel_ctx *zip_ctx = crypto_tfm_ctx(tfm);

ret = zip_decompress(src, slen, dst, dlen, zip_ctx);

return ret;
return zip_decompress(src, slen, dst, dlen, zip_ctx);
} /* Legacy compress framework end */

/* SCOMP framework start */
Expand Down Expand Up @@ -298,22 +286,16 @@ int zip_scomp_compress(struct crypto_scomp *tfm,
const u8 *src, unsigned int slen,
u8 *dst, unsigned int *dlen, void *ctx)
{
int ret;
struct zip_kernel_ctx *zip_ctx = ctx;

ret = zip_compress(src, slen, dst, dlen, zip_ctx);

return ret;
return zip_compress(src, slen, dst, dlen, zip_ctx);
}

int zip_scomp_decompress(struct crypto_scomp *tfm,
const u8 *src, unsigned int slen,
u8 *dst, unsigned int *dlen, void *ctx)
{
int ret;
struct zip_kernel_ctx *zip_ctx = ctx;

ret = zip_decompress(src, slen, dst, dlen, zip_ctx);

return ret;
return zip_decompress(src, slen, dst, dlen, zip_ctx);
} /* SCOMP framework end */

0 comments on commit 4edff84

Please sign in to comment.