Skip to content

Commit

Permalink
net: phy: broadcom: Correct BCM5221 PHY model detection
Browse files Browse the repository at this point in the history
Correct detect condition is applied to the entire 5221 family of PHYs.

Fixes: 3abbd06 ("net: phy: broadcom: add support for BCM5221 phy")
Signed-off-by: Jim Liu <jim.t90615@gmail.com>
Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Jim Liu authored and David S. Miller committed Mar 31, 2025
1 parent 2ea3964 commit 4f1eaab
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions drivers/net/phy/broadcom.c
Original file line number Diff line number Diff line change
Expand Up @@ -859,7 +859,7 @@ static int brcm_fet_config_init(struct phy_device *phydev)
return reg;

/* Unmask events we are interested in and mask interrupts globally. */
if (phydev->phy_id == PHY_ID_BCM5221)
if (phydev->drv->phy_id == PHY_ID_BCM5221)
reg = MII_BRCM_FET_IR_ENABLE |
MII_BRCM_FET_IR_MASK;
else
Expand Down Expand Up @@ -888,7 +888,7 @@ static int brcm_fet_config_init(struct phy_device *phydev)
return err;
}

if (phydev->phy_id != PHY_ID_BCM5221) {
if (phydev->drv->phy_id != PHY_ID_BCM5221) {
/* Set the LED mode */
reg = __phy_read(phydev, MII_BRCM_FET_SHDW_AUXMODE4);
if (reg < 0) {
Expand Down Expand Up @@ -1009,7 +1009,7 @@ static int brcm_fet_suspend(struct phy_device *phydev)
return err;
}

if (phydev->phy_id == PHY_ID_BCM5221)
if (phydev->drv->phy_id == PHY_ID_BCM5221)
/* Force Low Power Mode with clock enabled */
reg = BCM5221_SHDW_AM4_EN_CLK_LPM | BCM5221_SHDW_AM4_FORCE_LPM;
else
Expand Down

0 comments on commit 4f1eaab

Please sign in to comment.