Skip to content

Commit

Permalink
cpufreq: scmi: Avoid one OF parsing in scmi_get_sharing_cpus()
Browse files Browse the repository at this point in the history
The domain-id for the cpu_dev has already been parsed at the point when
scmi_get_sharing_cpus() is getting called. Let's pass it as an in-parameter
to avoid the unnecessary OF parsing.

Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Link: https://lore.kernel.org/r/20230825112633.236607-7-ulf.hansson@linaro.org
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
  • Loading branch information
Ulf Hansson authored and Sudeep Holla committed Sep 21, 2023
1 parent 9b578d8 commit 4f1f0bc
Showing 1 changed file with 4 additions and 7 deletions.
11 changes: 4 additions & 7 deletions drivers/cpufreq/scmi-cpufreq.c
Original file line number Diff line number Diff line change
Expand Up @@ -82,15 +82,12 @@ static int scmi_cpu_domain_id(struct device *cpu_dev)
}

static int
scmi_get_sharing_cpus(struct device *cpu_dev, struct cpumask *cpumask)
scmi_get_sharing_cpus(struct device *cpu_dev, int domain,
struct cpumask *cpumask)
{
int cpu, domain, tdomain;
int cpu, tdomain;
struct device *tcpu_dev;

domain = scmi_cpu_domain_id(cpu_dev);
if (domain < 0)
return domain;

for_each_possible_cpu(cpu) {
if (cpu == cpu_dev->id)
continue;
Expand Down Expand Up @@ -163,7 +160,7 @@ static int scmi_cpufreq_init(struct cpufreq_policy *policy)
}

/* Obtain CPUs that share SCMI performance controls */
ret = scmi_get_sharing_cpus(cpu_dev, policy->cpus);
ret = scmi_get_sharing_cpus(cpu_dev, domain, policy->cpus);
if (ret) {
dev_warn(cpu_dev, "failed to get sharing cpumask\n");
goto out_free_cpumask;
Expand Down

0 comments on commit 4f1f0bc

Please sign in to comment.