Skip to content

Commit

Permalink
sparc32: fix section mismatch warnings in apc, pmc and time_32
Browse files Browse the repository at this point in the history
In all cases there were a struct of_device_id variable defined __initdata.
But it was referenced from struct platform_driver.of_match_table
which is not guaranteed to be used during init only.

So drop the __initdata annotation.

This fixes following warnings:

WARNING: arch/sparc/kernel/built-in.o(.data+0x810): Section mismatch in reference from the variable clock_driver to the variable .init.data:clock_match
The variable clock_driver references
the variable __initdata clock_match
If the reference is valid then annotate the
variable with __init* or __refdata (see linux/init.h) or name the variable:
*_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console

WARNING: arch/sparc/kernel/built-in.o(.data+0xcec): Section mismatch in reference from the variable apc_driver to the variable .init.data:apc_match
The variable apc_driver references
the variable __initdata apc_match
If the reference is valid then annotate the
variable with __init* or __refdata (see linux/init.h) or name the variable:
*_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console

WARNING: arch/sparc/kernel/built-in.o(.data+0xd60): Section mismatch in reference from the variable pmc_driver to the variable .init.data:pmc_match
The variable pmc_driver references
the variable __initdata pmc_match
If the reference is valid then annotate the
variable with __init* or __refdata (see linux/init.h) or name the variable:
*_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Sam Ravnborg authored and David S. Miller committed Apr 21, 2011
1 parent 2f666bc commit 505d914
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion arch/sparc/kernel/apc.c
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ static int __devinit apc_probe(struct platform_device *op)
return 0;
}

static struct of_device_id __initdata apc_match[] = {
static struct of_device_id apc_match[] = {
{
.name = APC_OBPNAME,
},
Expand Down
2 changes: 1 addition & 1 deletion arch/sparc/kernel/pmc.c
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ static int __devinit pmc_probe(struct platform_device *op)
return 0;
}

static struct of_device_id __initdata pmc_match[] = {
static struct of_device_id pmc_match[] = {
{
.name = PMC_OBPNAME,
},
Expand Down
2 changes: 1 addition & 1 deletion arch/sparc/kernel/time_32.c
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ static int __devinit clock_probe(struct platform_device *op)
return 0;
}

static struct of_device_id __initdata clock_match[] = {
static struct of_device_id clock_match[] = {
{
.name = "eeprom",
},
Expand Down

0 comments on commit 505d914

Please sign in to comment.