Skip to content

Commit

Permalink
bus: sun50i-de2: Adjust printing error message
Browse files Browse the repository at this point in the history
SRAM driver often returns -EPROBE_DEFER and thus this bus driver often
prints error message, even if it probes successfully later. This is
confusing for users and they often think that something is wrong.

Use dev_err_probe() helper for printing error message. It handles
-EPROBE_DEFER automatically.

Signed-off-by: Jernej Skrabec <jernej.skrabec@gmail.com>
Reviewed-by: Andre Przywara <andre.przywara@arm.com>
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
Link: https://lore.kernel.org/r/20211010071812.145178-1-jernej.skrabec@gmail.com
  • Loading branch information
Jernej Skrabec authored and Maxime Ripard committed Oct 13, 2021
1 parent 1f3753a commit 50ac48a
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions drivers/bus/sun50i-de2.c
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,9 @@ static int sun50i_de2_bus_probe(struct platform_device *pdev)
int ret;

ret = sunxi_sram_claim(&pdev->dev);
if (ret) {
dev_err(&pdev->dev, "Error couldn't map SRAM to device\n");
return ret;
}
if (ret)
return dev_err_probe(&pdev->dev, ret,
"Couldn't map SRAM to device\n");

of_platform_populate(np, NULL, NULL, &pdev->dev);

Expand Down

0 comments on commit 50ac48a

Please sign in to comment.