Skip to content

Commit

Permalink
clk: qcom: Consolidate frequency finding logic
Browse files Browse the repository at this point in the history
There are two find_freq() functions in clk-rcg.c and clk-rcg2.c
that are almost exactly the same. Consolidate them into one
function to save on some code space.

Cc: Mike Turquette <mturquette@linaro.org>
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
  • Loading branch information
Stephen Boyd committed Sep 22, 2014
1 parent dc1b3f6 commit 50c6a50
Show file tree
Hide file tree
Showing 4 changed files with 27 additions and 32 deletions.
20 changes: 4 additions & 16 deletions drivers/clk/qcom/clk-rcg.c
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
#include <asm/div64.h>

#include "clk-rcg.h"
#include "common.h"

static u32 ns_to_src(struct src_sel *s, u32 ns)
{
Expand Down Expand Up @@ -360,26 +361,13 @@ clk_dyn_rcg_recalc_rate(struct clk_hw *hw, unsigned long parent_rate)
}
}

static const
struct freq_tbl *find_freq(const struct freq_tbl *f, unsigned long rate)
{
if (!f)
return NULL;

for (; f->freq; f++)
if (rate <= f->freq)
return f;

return NULL;
}

static long _freq_tbl_determine_rate(struct clk_hw *hw,
const struct freq_tbl *f, unsigned long rate,
unsigned long *p_rate, struct clk **p)
{
unsigned long clk_flags;

f = find_freq(f, rate);
f = qcom_find_freq(f, rate);
if (!f)
return -EINVAL;

Expand Down Expand Up @@ -477,7 +465,7 @@ static int clk_rcg_set_rate(struct clk_hw *hw, unsigned long rate,
struct clk_rcg *rcg = to_clk_rcg(hw);
const struct freq_tbl *f;

f = find_freq(rcg->freq_tbl, rate);
f = qcom_find_freq(rcg->freq_tbl, rate);
if (!f)
return -EINVAL;

Expand All @@ -497,7 +485,7 @@ static int __clk_dyn_rcg_set_rate(struct clk_hw *hw, unsigned long rate)
struct clk_dyn_rcg *rcg = to_clk_dyn_rcg(hw);
const struct freq_tbl *f;

f = find_freq(rcg->freq_tbl, rate);
f = qcom_find_freq(rcg->freq_tbl, rate);
if (!f)
return -EINVAL;

Expand Down
19 changes: 3 additions & 16 deletions drivers/clk/qcom/clk-rcg2.c
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
#include <asm/div64.h>

#include "clk-rcg.h"
#include "common.h"

#define CMD_REG 0x0
#define CMD_UPDATE BIT(0)
Expand Down Expand Up @@ -172,27 +173,13 @@ clk_rcg2_recalc_rate(struct clk_hw *hw, unsigned long parent_rate)
return calc_rate(parent_rate, m, n, mode, hid_div);
}

static const
struct freq_tbl *find_freq(const struct freq_tbl *f, unsigned long rate)
{
if (!f)
return NULL;

for (; f->freq; f++)
if (rate <= f->freq)
return f;

/* Default to our fastest rate */
return f - 1;
}

static long _freq_tbl_determine_rate(struct clk_hw *hw,
const struct freq_tbl *f, unsigned long rate,
unsigned long *p_rate, struct clk **p)
{
unsigned long clk_flags;

f = find_freq(f, rate);
f = qcom_find_freq(f, rate);
if (!f)
return -EINVAL;

Expand Down Expand Up @@ -268,7 +255,7 @@ static int __clk_rcg2_set_rate(struct clk_hw *hw, unsigned long rate)
struct clk_rcg2 *rcg = to_clk_rcg2(hw);
const struct freq_tbl *f;

f = find_freq(rcg->freq_tbl, rate);
f = qcom_find_freq(rcg->freq_tbl, rate);
if (!f)
return -EINVAL;

Expand Down
16 changes: 16 additions & 0 deletions drivers/clk/qcom/common.c
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
#include <linux/reset-controller.h>

#include "common.h"
#include "clk-rcg.h"
#include "clk-regmap.h"
#include "reset.h"

Expand All @@ -27,6 +28,21 @@ struct qcom_cc {
struct clk *clks[];
};

const
struct freq_tbl *qcom_find_freq(const struct freq_tbl *f, unsigned long rate)
{
if (!f)
return NULL;

for (; f->freq; f++)
if (rate <= f->freq)
return f;

/* Default to our fastest rate */
return f - 1;
}
EXPORT_SYMBOL_GPL(qcom_find_freq);

struct regmap *
qcom_cc_map(struct platform_device *pdev, const struct qcom_cc_desc *desc)
{
Expand Down
4 changes: 4 additions & 0 deletions drivers/clk/qcom/common.h
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ struct regmap_config;
struct clk_regmap;
struct qcom_reset_map;
struct regmap;
struct freq_tbl;

struct qcom_cc_desc {
const struct regmap_config *config;
Expand All @@ -27,6 +28,9 @@ struct qcom_cc_desc {
size_t num_resets;
};

extern const struct freq_tbl *qcom_find_freq(const struct freq_tbl *f,
unsigned long rate);

extern struct regmap *qcom_cc_map(struct platform_device *pdev,
const struct qcom_cc_desc *desc);
extern int qcom_cc_really_probe(struct platform_device *pdev,
Expand Down

0 comments on commit 50c6a50

Please sign in to comment.