Skip to content

Commit

Permalink
can: gs_usb: gs_make_candev(): fix memory leak for devices with exten…
Browse files Browse the repository at this point in the history
…ded bit timing configuration

Some CAN-FD capable devices offer extended bit timing information for
the data bit timing. The information must be read with an USB control
message. The memory for this message is allocated but not free()ed (in
the non error case). This patch adds the missing free.

Fixes: 6679f4c ("can: gs_usb: add extended bt_const feature")
Link: https://lore.kernel.org/all/20220329193450.659726-1-mkl@pengutronix.de
Reported-by: syzbot+4d0ae90a195b269f102d@syzkaller.appspotmail.com
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
  • Loading branch information
Marc Kleine-Budde committed Mar 31, 2022
1 parent 136bed0 commit 50d34a0
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions drivers/net/can/usb/gs_usb.c
Original file line number Diff line number Diff line change
Expand Up @@ -1092,6 +1092,8 @@ static struct gs_can *gs_make_candev(unsigned int channel,
dev->data_bt_const.brp_inc = le32_to_cpu(bt_const_extended->dbrp_inc);

dev->can.data_bittiming_const = &dev->data_bt_const;

kfree(bt_const_extended);
}

SET_NETDEV_DEV(netdev, &intf->dev);
Expand Down

0 comments on commit 50d34a0

Please sign in to comment.