Skip to content

Commit

Permalink
dm space map metadata: remove unused variable in brb_pop()
Browse files Browse the repository at this point in the history
Remove the unused struct block_op pointer that was inadvertantly
introduced, via cut-and-paste of previous brb_op() code, as part of
commit 50dd842.

(Cc'ing stable@ because commit 50dd842 did)

Fixes: 50dd842 ("dm space map metadata: fix ref counting bug when bootstrapping a new space map")
Reported-by: David Binderman <dcb314@hotmail.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
Cc: stable@vger.kernel.org
  • Loading branch information
Mike Snitzer committed Dec 14, 2015
1 parent 0cc37c2 commit 5121677
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions drivers/md/persistent-data/dm-space-map-metadata.c
Original file line number Diff line number Diff line change
@@ -152,12 +152,9 @@ static int brb_peek(struct bop_ring_buffer *brb, struct block_op *result)

static int brb_pop(struct bop_ring_buffer *brb)
{
struct block_op *bop;

if (brb_empty(brb))
return -ENODATA;

bop = brb->bops + brb->begin;
brb->begin = brb_next(brb, brb->begin);

return 0;

0 comments on commit 5121677

Please sign in to comment.