Skip to content

Commit

Permalink
block: remove superfluous calls to blkcg_bio_issue_init
Browse files Browse the repository at this point in the history
blkcg_bio_issue_init is called in submit_bio.  There is no need to have
extra calls that just get overriden in __bio_clone and the two places
that copy and pasted from it.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Mike Snitzer <snitzer@kernel.org>
Link: https://lore.kernel.org/r/20220504142950.567582-2-hch@lst.de
Signed-off-by: Jens Axboe <axboe@kernel.dk>
  • Loading branch information
Christoph Hellwig authored and Jens Axboe committed May 5, 2022
1 parent f624506 commit 5136168
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 3 deletions.
1 change: 0 additions & 1 deletion block/bio.c
Original file line number Diff line number Diff line change
Expand Up @@ -768,7 +768,6 @@ static int __bio_clone(struct bio *bio, struct bio *bio_src, gfp_t gfp)
bio->bi_iter = bio_src->bi_iter;

bio_clone_blkg_association(bio, bio_src);
blkcg_bio_issue_init(bio);

if (bio_crypt_clone(bio, bio_src, gfp) < 0)
return -ENOMEM;
Expand Down
1 change: 0 additions & 1 deletion block/blk-crypto-fallback.c
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,6 @@ static struct bio *blk_crypto_fallback_clone_bio(struct bio *bio_src)
bio->bi_io_vec[bio->bi_vcnt++] = bv;

bio_clone_blkg_association(bio, bio_src);
blkcg_bio_issue_init(bio);

return bio;
}
Expand Down
1 change: 0 additions & 1 deletion block/bounce.c
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,6 @@ static struct bio *bounce_clone_bio(struct bio *bio_src)
goto err_put;

bio_clone_blkg_association(bio, bio_src);
blkcg_bio_issue_init(bio);

return bio;

Expand Down

0 comments on commit 5136168

Please sign in to comment.