Skip to content

Commit

Permalink
ktest.pl: Fix combined usage of BISECT_REVERSE and BISECT_SKIP
Browse files Browse the repository at this point in the history
When BISECT_REVERSE and BISECT_SKIP are used together with boot or test
testing, build failures are treated as boot or test failures and
'git bisect bad' is executed instead of 'git bisect skip'. This is because
the $ret value of -1 is treated as a build failure, but the $reverse_bisect
logic does not properly handle this.

Simple fix, only invert it if it is positive.

Link: http://lkml.kernel.org/r/1335235380-8509-1-git-send-email-Russ.Dill@ti.com

Signed-off-by: Russ Dill <Russ.Dill@ti.com>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
  • Loading branch information
Russ Dill authored and Steven Rostedt committed May 1, 2012
1 parent 66f75a5 commit 5158ba3
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tools/testing/ktest/ktest.pl
Original file line number Diff line number Diff line change
Expand Up @@ -2192,7 +2192,7 @@ sub run_bisect {
}

# Are we looking for where it worked, not failed?
if ($reverse_bisect) {
if ($reverse_bisect && $ret >= 0) {
$ret = !$ret;
}

Expand Down

0 comments on commit 5158ba3

Please sign in to comment.