Skip to content

Commit

Permalink
powerpc/xive: Simplify xive_core_debug_show()
Browse files Browse the repository at this point in the history
Now that the IPI interrupt has its own domain, the checks on the HW
interrupt number XIVE_IPI_HW_IRQ and on the chip can be replaced by a
check on the domain.

Signed-off-by: Cédric Le Goater <clg@kaod.org>
Reviewed-by: Greg Kurz <groug@kaod.org>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20210331144514.892250-5-clg@kaod.org
  • Loading branch information
Cédric Le Goater authored and Michael Ellerman committed Apr 14, 2021
1 parent 1835e72 commit 5159d98
Showing 1 changed file with 4 additions and 14 deletions.
18 changes: 4 additions & 14 deletions arch/powerpc/sysdev/xive/common.c
Original file line number Diff line number Diff line change
Expand Up @@ -1604,17 +1604,14 @@ static void xive_debug_show_cpu(struct seq_file *m, int cpu)
seq_puts(m, "\n");
}

static void xive_debug_show_irq(struct seq_file *m, u32 hw_irq, struct irq_data *d)
static void xive_debug_show_irq(struct seq_file *m, struct irq_data *d)
{
struct irq_chip *chip = irq_data_get_irq_chip(d);
unsigned int hw_irq = (unsigned int)irqd_to_hwirq(d);
int rc;
u32 target;
u8 prio;
u32 lirq;

if (!is_xive_irq(chip))
return;

rc = xive_ops->get_irq_config(hw_irq, &target, &prio, &lirq);
if (rc) {
seq_printf(m, "IRQ 0x%08x : no config rc=%d\n", hw_irq, rc);
Expand Down Expand Up @@ -1652,16 +1649,9 @@ static int xive_core_debug_show(struct seq_file *m, void *private)

for_each_irq_desc(i, desc) {
struct irq_data *d = irq_desc_get_irq_data(desc);
unsigned int hw_irq;

if (!d)
continue;

hw_irq = (unsigned int)irqd_to_hwirq(d);

/* IPIs are special (HW number 0) */
if (hw_irq != XIVE_IPI_HW_IRQ)
xive_debug_show_irq(m, hw_irq, d);
if (d->domain == xive_irq_domain)
xive_debug_show_irq(m, d);
}
return 0;
}
Expand Down

0 comments on commit 5159d98

Please sign in to comment.