Skip to content

Commit

Permalink
Merge tag 'locking-urgent-2024-08-25' of git://git.kernel.org/pub/scm…
Browse files Browse the repository at this point in the history
…/linux/kernel/git/tip/tip

Pull locking fix from Thomas Gleixner:
 "A single fix for rt_mutex.

  The deadlock detection code drops into an infinite scheduling loop
  while still holding rt_mutex::wait_lock, which rightfully triggers a
  'scheduling in atomic' warning.

  Unlock it before that"

* tag 'locking-urgent-2024-08-25' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip:
  rtmutex: Drop rt_mutex::wait_lock before scheduling
  • Loading branch information
Linus Torvalds committed Sep 1, 2024
2 parents 9a75429 + d33d260 commit 51859c5
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions kernel/locking/rtmutex.c
Original file line number Diff line number Diff line change
Expand Up @@ -1644,6 +1644,7 @@ static int __sched rt_mutex_slowlock_block(struct rt_mutex_base *lock,
}

static void __sched rt_mutex_handle_deadlock(int res, int detect_deadlock,
struct rt_mutex_base *lock,
struct rt_mutex_waiter *w)
{
/*
Expand All @@ -1656,10 +1657,10 @@ static void __sched rt_mutex_handle_deadlock(int res, int detect_deadlock,
if (build_ww_mutex() && w->ww_ctx)
return;

/*
* Yell loudly and stop the task right here.
*/
raw_spin_unlock_irq(&lock->wait_lock);

WARN(1, "rtmutex deadlock detected\n");

while (1) {
set_current_state(TASK_INTERRUPTIBLE);
rt_mutex_schedule();
Expand Down Expand Up @@ -1713,7 +1714,7 @@ static int __sched __rt_mutex_slowlock(struct rt_mutex_base *lock,
} else {
__set_current_state(TASK_RUNNING);
remove_waiter(lock, waiter);
rt_mutex_handle_deadlock(ret, chwalk, waiter);
rt_mutex_handle_deadlock(ret, chwalk, lock, waiter);
}

/*
Expand Down

0 comments on commit 51859c5

Please sign in to comment.