Skip to content

Commit

Permalink
dm-verity: do forward error correction on metadata I/O errors
Browse files Browse the repository at this point in the history
Do forward error correction if metadata I/O fails.

Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
Reviewed-by: Sami Tolvanen <samitolvanen@google.com>
  • Loading branch information
Mikulas Patocka committed Feb 24, 2025
1 parent 3be1f25 commit 51ba14f
Showing 1 changed file with 21 additions and 4 deletions.
25 changes: 21 additions & 4 deletions drivers/md/dm-verity-target.c
Original file line number Diff line number Diff line change
Expand Up @@ -311,7 +311,7 @@ static int verity_verify_level(struct dm_verity *v, struct dm_verity_io *io,

if (static_branch_unlikely(&use_bh_wq_enabled) && io->in_bh) {
data = dm_bufio_get(v->bufio, hash_block, &buf);
if (data == NULL) {
if (IS_ERR_OR_NULL(data)) {
/*
* In tasklet and the hash was not in the bufio cache.
* Return early and resume execution from a work-queue
Expand All @@ -324,8 +324,24 @@ static int verity_verify_level(struct dm_verity *v, struct dm_verity_io *io,
&buf, bio->bi_ioprio);
}

if (IS_ERR(data))
return PTR_ERR(data);
if (IS_ERR(data)) {
if (skip_unverified)
return 1;
r = PTR_ERR(data);
data = dm_bufio_new(v->bufio, hash_block, &buf);
if (IS_ERR(data))
return r;
if (verity_fec_decode(v, io, DM_VERITY_BLOCK_TYPE_METADATA,
hash_block, data) == 0) {
aux = dm_bufio_get_aux_data(buf);
aux->hash_verified = 1;
goto release_ok;
} else {
dm_bufio_release(buf);
dm_bufio_forget(v->bufio, hash_block);
return r;
}
}

aux = dm_bufio_get_aux_data(buf);

Expand Down Expand Up @@ -366,6 +382,7 @@ static int verity_verify_level(struct dm_verity *v, struct dm_verity_io *io,
}
}

release_ok:
data += offset;
memcpy(want_digest, data, v->digest_size);
r = 0;
Expand Down Expand Up @@ -1761,7 +1778,7 @@ static struct target_type verity_target = {
.name = "verity",
/* Note: the LSMs depend on the singleton and immutable features */
.features = DM_TARGET_SINGLETON | DM_TARGET_IMMUTABLE,
.version = {1, 10, 0},
.version = {1, 11, 0},
.module = THIS_MODULE,
.ctr = verity_ctr,
.dtr = verity_dtr,
Expand Down

0 comments on commit 51ba14f

Please sign in to comment.