Skip to content

Commit

Permalink
libbpf: Fix overrun in netlink attribute iteration
Browse files Browse the repository at this point in the history
I accidentally found that a change in commit 1045b03 ("netlink: fix
overrun in attribute iteration") was not synchronized to the function
`nla_ok` in tools/lib/bpf/nlattr.c, I think it is necessary to modify,
this patch will do it.

Signed-off-by: Xin Liu <liuxin350@huawei.com>
Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
Link: https://lore.kernel.org/bpf/20220930090708.62394-1-liuxin350@huawei.com
  • Loading branch information
Xin Liu authored and Andrii Nakryiko committed Sep 30, 2022
1 parent 2efcf69 commit 51e05a8
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tools/lib/bpf/nlattr.c
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ static struct nlattr *nla_next(const struct nlattr *nla, int *remaining)

static int nla_ok(const struct nlattr *nla, int remaining)
{
return remaining >= sizeof(*nla) &&
return remaining >= (int)sizeof(*nla) &&
nla->nla_len >= sizeof(*nla) &&
nla->nla_len <= remaining;
}
Expand Down

0 comments on commit 51e05a8

Please sign in to comment.