Skip to content

Commit

Permalink
fsnotify: use def_bool in kconfig instead of letting the user choose
Browse files Browse the repository at this point in the history
fsnotify doens't give the user anything.  If someone chooses inotify or
dnotify it should build fsnotify, if they don't select one it shouldn't be
built.  This patch changes fsnotify to be a def_bool=n and makes everything
else select it.  Also fixes the issue people complained about on lwn where
gdm hung because they didn't have inotify and they didn't get the inotify
build option.....

Signed-off-by: Eric Paris <eparis@redhat.com>
  • Loading branch information
Eric Paris committed Jul 21, 2009
1 parent 7e790dd commit 520dc2a
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 13 deletions.
12 changes: 1 addition & 11 deletions fs/notify/Kconfig
Original file line number Diff line number Diff line change
@@ -1,15 +1,5 @@
config FSNOTIFY
bool "Filesystem notification backend"
default y
---help---
fsnotify is a backend for filesystem notification. fsnotify does
not provide any userspace interface but does provide the basis
needed for other notification schemes such as dnotify, inotify,
and fanotify.

Say Y here to enable fsnotify suport.

If unsure, say Y.
def_bool n

source "fs/notify/dnotify/Kconfig"
source "fs/notify/inotify/Kconfig"
2 changes: 1 addition & 1 deletion fs/notify/dnotify/Kconfig
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
config DNOTIFY
bool "Dnotify support"
depends on FSNOTIFY
select FSNOTIFY
default y
help
Dnotify is a directory-based per-fd file change notification system
Expand Down
2 changes: 1 addition & 1 deletion fs/notify/inotify/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ config INOTIFY

config INOTIFY_USER
bool "Inotify support for userspace"
depends on FSNOTIFY
select FSNOTIFY
default y
---help---
Say Y here to enable inotify support for userspace, including the
Expand Down

0 comments on commit 520dc2a

Please sign in to comment.