Skip to content

Commit

Permalink
powerpc: Check rc of notifier chain for memory remove
Browse files Browse the repository at this point in the history
The return code from invocation of the notifier for
pSeries_reconfig_chain during update of the device tree is not
checked.  This causes writes to /proc/ppc64/ofdt to update memory
properties (i.e. ibm,dyamic-reconfiguration-memory) to always
return success, instead of the result of the notifier chain.

This happens specifically when we remove/add memory from the
device tree on machines using memory specified in the
ibm,dynamic-reconfiguration-memory property of the device tree.

Signed-off-by: Nathan Fontenot <nfont@austin.ibm.com>
Signed-off-by: Paul Mackerras <paulus@samba.org>
  • Loading branch information
Nathan Fontenot authored and Paul Mackerras committed Sep 15, 2008
1 parent 57dda6e commit 525c411
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions arch/powerpc/platforms/pseries/reconfig.c
Original file line number Diff line number Diff line change
Expand Up @@ -466,11 +466,11 @@ static int do_update_property(char *buf, size_t bufsize)
else
action = PSERIES_DRCONF_MEM_REMOVE;

blocking_notifier_call_chain(&pSeries_reconfig_chain,
action, value);
rc = blocking_notifier_call_chain(&pSeries_reconfig_chain,
action, value);
}

return 0;
return rc;
}

/**
Expand Down

0 comments on commit 525c411

Please sign in to comment.